fix(ci): further consolidate NODE_OPTIONS #12217
Open
+13
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
product
datahub-cyborg
bot
added
the
needs-review
david-leifker
force-pushed
the
node-options-consilidation
branch
from
985476a to
44566ab
Compare
david-leifker
force-pushed
the
node-options-consilidation
branch
from
44566ab to
2390b28
Compare
david-leifker
force-pushed
the
node-options-consilidation
branch
from
2390b28 to
79088ac
Compare
hsheth2
approved these changes
Dec 24, 2024
datahub-web-react/package.json
Outdated
| "analyze": "NODE_OPTIONS='--max-old-space-size=5120 --openssl-legacy-provider' source-map-explorer 'dist/assets/*.js'", | ||
| "start": "NODE_OPTIONS='--max-old-space-size=5120 --openssl-legacy-provider' yarn run generate && NODE_OPTIONS='--max-old-space-size=5120 --openssl-legacy-provider' vite", | ||
| "ec2-dev": "NODE_OPTIONS='--max-old-space-size=5120 --openssl-legacy-provider' yarn run generate && CI=true NODE_OPTIONS='--max-old-space-size=5120 --openssl-legacy-provider' vite", | ||
| "build": "NODE_OPTIONS='--max-old-space-size=5120 --openssl-legacy-provider' yarn run generate && CI=false NODE_OPTIONS='--max-old-space-size=5120 --openssl-legacy-provider' vite build", |
There was a problem hiding this comment.
this should only be necessary on the vite build step
There was a problem hiding this comment.
Removed it from several of them. The storybook build causes OOM in Saas. Enabling coverage on the test also triggers OOM, so more then just vite build is likely warranted.
david-leifker
force-pushed
the
node-options-consilidation
branch
from
79088ac to
dc0d6bb
Compare
datahub-cyborg
bot
added
pending-submitter-merge
and removed
needs-review
david-leifker
force-pushed
the
node-options-consilidation
branch
from
dc0d6bb to
a80d6a5
Compare
david-leifker
force-pushed
the
node-options-consilidation
branch
from
a80d6a5 to
f1eaba6
Compare
chakru-r
reviewed
Dec 24, 2024
| @@ -79,7 +79,7 @@ task yarnServe(type: YarnTask, dependsOn: [yarnInstall, yarnGenerate]) { | |||
|
|
|||
| task yarnTest(type: YarnTask, dependsOn: [yarnInstall, yarnGenerate]) { | |||
| // Explicitly runs in non-watch mode. | |||
| args = ['run', 'test', 'run'] | |||
| args = ['run', project.hasProperty('withCoverage') ? 'test-coverage' : 'test', 'run'] | |||
There was a problem hiding this comment.
Where is this property being set? We would want the coverage to be generated when gradle runs the test task (like all other projects).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent having to track down and modify memory settings in multiple places for NODE_OPTIONS
Checklist