Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tableau): fixes wrong argument when reauthenticating #12216

Merged
merged 10 commits into from
Dec 24, 2024
Merged

fix(tableau): fixes wrong argument when reauthenticating #12216

merged 10 commits into from
Dec 24, 2024

Conversation

sgomezvillamor
Copy link
Contributor

@sgomezvillamor sgomezvillamor commented Dec 23, 2024 •
edited
Loading

Re-authentication issues were caused by passing site_id when content_url is expected.

Tested locally


⏳ Pipeline running with at least 1 warnings so far; produced 500 events in 2 hours, 3 minutes and 44.17 seconds.
|[2024-12-24 09:51:51,831] INFO     {datahub.ingestion.source.tableau.tableau:913} - Re-authenticating to Tableau site='acryldatatableaupartnershipportal'

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Dec 23, 2024
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Dec 23, 2024
@sgomezvillamor sgomezvillamor enabled auto-merge (squash) December 24, 2024 09:22
@datahub-cyborg datahub-cyborg bot added pending-submitter-merge and removed needs-review Label for PRs that need review from a maintainer. labels Dec 24, 2024
@sgomezvillamor sgomezvillamor merged commit d88e6c9 into master Dec 24, 2024
76 checks passed
@sgomezvillamor sgomezvillamor deleted the feature/cus-3546-fix-tableau-authentication branch December 24, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mayurinehate mayurinehate mayurinehate approved these changes

@hsheth2 hsheth2 Awaiting requested review from hsheth2

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata pending-submitter-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sgomezvillamor @mayurinehate