Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ingest/lookml): emit warnings for resolution failures #12215

Merged
merged 2 commits into from
Dec 26, 2024

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Dec 23, 2024

In most cases, these indicate minor syntax errors. Now that we have a warning state, it's more appropriate than failure.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

In most cases, these indicate minor syntax errors. Now that we have a
warning state, it's more appropriate than failure.
@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Dec 23, 2024
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Dec 23, 2024
@datahub-cyborg datahub-cyborg bot added pending-submitter-merge and removed needs-review Label for PRs that need review from a maintainer. labels Dec 24, 2024
@hsheth2 hsheth2 merged commit a920e9b into master Dec 26, 2024
101 of 104 checks passed
@hsheth2 hsheth2 deleted the cus-3497-looker-view-resolver-failure branch December 26, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ingestion PR or Issue related to the ingestion of metadata pending-submitter-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants