-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(tableau): retry on InternalServerError 504 #12213
fix(tableau): retry on InternalServerError 504 #12213
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving to unblock
current_cursor=current_cursor, | ||
retry_on_auth_error=False, | ||
retries_remaining=retries_remaining - 1, | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need an else: raise
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indeed
fetch_size=fetch_size, | ||
current_cursor=current_cursor, | ||
retry_on_auth_error=False, | ||
retries_remaining=retries_remaining - 1, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not a huge fan of this entire method - it feels way more complicated than it needs to be and has a ton of mostly duplicated code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree
If this works, we should invest some time on a refactor.
Retries on the following case
Checklist