Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingest): exclude aspect from migration #12206

Merged
merged 1 commit into from
Dec 23, 2024
Merged

fix(ingest): exclude aspect from migration #12206

merged 1 commit into from
Dec 23, 2024

Conversation

anshbansal
Copy link
Collaborator

These aspects migrated to new instance will cause problems

  • Ingestion runs don't add value
  • Ingestion secrets cannot be decoded due to different encryption keys
  • Global settings have encrypted values and SSO url from previous instance which will cause SSO of new instance to not work

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Dec 23, 2024
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Dec 23, 2024
@datahub-cyborg datahub-cyborg bot added pending-submitter-merge and removed needs-review Label for PRs that need review from a maintainer. labels Dec 23, 2024
@anshbansal anshbansal added merge-pending-ci A PR that has passed review and should be merged once CI is green. and removed pending-submitter-merge labels Dec 23, 2024
@anshbansal anshbansal merged commit 0562c7a into master Dec 23, 2024
117 of 157 checks passed
@anshbansal anshbansal deleted the ab-exclude-aspects-migration branch December 23, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgomezvillamor sgomezvillamor sgomezvillamor approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata merge-pending-ci A PR that has passed review and should be merged once CI is green.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anshbansal @sgomezvillamor