Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ingest/looker): Add flag for Looker metadata extraction #12205

Merged
merged 4 commits into from
Dec 24, 2024
Merged

fix(ingest/looker): Add flag for Looker metadata extraction #12205

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d3b75c7
fix(ingest/looker): Add flag for Looker metadata extraction
sagar-salvi-apptware Dec 23, 2024
2700b64
Update metadata-ingestion/src/datahub/sql_parsing/tool_meta_extractor.py
sagar-salvi-apptware Dec 23, 2024
6738c2f
Update metadata-ingestion/src/datahub/sql_parsing/tool_meta_extractor.py
sagar-salvi-apptware Dec 23, 2024
e4cef6f
Merge branch 'master' into fix/looker-metadata-extraction-flag
mayurinehate Dec 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion metadata-ingestion/src/datahub/sql_parsing/tool_meta_extractor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ def _get_last_line(query: str) -> str:
class ToolMetaExtractorReport(Report):
num_queries_meta_extracted: Dict[str, int] = field(default_factory=int_top_k_dict)
failures: List[str] = field(default_factory=list)
looker_mapping_missing = False
sagar-salvi-apptware marked this conversation as resolved.
Show resolved Hide resolved


class ToolMetaExtractor:
Expand Down Expand Up @@ -108,7 +109,9 @@ def extract_looker_user_mapping_from_graph(
PlatformResource.search_by_filters(query=query, graph_client=graph)
)

if len(platform_resources) > 1:
if len(platform_resources) == 0:
report.looker_mapping_missing = True
sagar-salvi-apptware marked this conversation as resolved.
Show resolved Hide resolved
elif len(platform_resources) > 1:
report.failures.append(
"Looker user metadata extraction failed. Found more than one looker user id mappings."
)
Expand Down
Loading