Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui): null dereference #12193

Merged
merged 3 commits into from
Dec 23, 2024
Merged

fix(ui): null dereference #12193

merged 3 commits into from
Dec 23, 2024

Conversation

anshbansal
Copy link
Collaborator

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the product PR or Issue related to the DataHub UI/UX label Dec 20, 2024
@anshbansal anshbansal marked this pull request as ready for review December 20, 2024 13:30
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Dec 20, 2024
sakethvarma397
sakethvarma397 approved these changes Dec 23, 2024
View reviewed changes
Copy link
Contributor

@sakethvarma397 sakethvarma397 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks safe

@datahub-cyborg datahub-cyborg bot added pending-submitter-merge and removed needs-review Label for PRs that need review from a maintainer. labels Dec 23, 2024
@anshbansal anshbansal merged commit dd23f9e into master Dec 23, 2024
62 of 67 checks passed
@anshbansal anshbansal deleted the ab-fix-null-dereference branch December 23, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sakethvarma397 sakethvarma397 sakethvarma397 approved these changes

@pedro93 pedro93 pedro93 approved these changes

Assignees
No one assigned
Labels
pending-submitter-merge product PR or Issue related to the DataHub UI/UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anshbansal @pedro93 @sakethvarma397