Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dagster): support dagster v1.9.6 #12189

Merged
merged 1 commit into from
Dec 20, 2024
Merged

fix(dagster): support dagster v1.9.6 #12189

merged 1 commit into from
Dec 20, 2024

Conversation

sgomezvillamor
Copy link
Contributor

dagster just released 1.9.6 and our builds are failling because of missing _asdict() method

InputSnapDef is not a NamedTuple anymore and so the missed method
dagster-io/dagster@1.9.5...1.9.6#diff-50a436e3f602ebee518a937a2415e1157663339bb01bfe925aa26790016a75e2

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Dec 20, 2024
@sgomezvillamor sgomezvillamor marked this pull request as ready for review December 20, 2024 08:51
@treff7es
Copy link
Contributor

Will this work with older Dagster versions as well?
If this was renamed, we should also support _asdict(); otherwise, it is okay.

@sgomezvillamor sgomezvillamor merged commit 66df362 into master Dec 20, 2024
49 of 50 checks passed
@sgomezvillamor sgomezvillamor deleted the fix-dagster-support-1-9-6 branch December 20, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@treff7es treff7es treff7es approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sgomezvillamor @treff7es