Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tableau): restart server object when reauthenticating #12182

Merged
merged 6 commits into from
Dec 20, 2024
Merged

fix(tableau): restart server object when reauthenticating #12182

Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f239189
fix(tableau): restart server object when reauthenticating
sgomezvillamor Dec 19, 2024
e005868
fix lint
sgomezvillamor Dec 19, 2024
4692800
fix call
sgomezvillamor Dec 19, 2024
932cd30
Merge branch 'master' into feature/cus-3540-fix-tableau-reauth
sgomezvillamor Dec 19, 2024
0947b78
Update metadata-ingestion/src/datahub/ingestion/source/tableau/tablea…
sgomezvillamor Dec 20, 2024
9ab0331
Merge branch 'master' into feature/cus-3540-fix-tableau-reauth
sgomezvillamor Dec 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions metadata-ingestion/src/datahub/ingestion/source/tableau/tableau.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -896,10 +896,9 @@ def dataset_browse_prefix(self) -> str:
return f"/{self.config.env.lower()}{self.no_env_browse_prefix}"

def _re_authenticate(self):
tableau_auth: Union[
TableauAuth, PersonalAccessTokenAuth
] = self.config.get_tableau_auth(self.site_id)
self.server.auth.sign_in(tableau_auth)
# Sign-in again may not be enough because Tableau sometimes caches invalid sessions
# so we need to restart the Tableau Server object
sgomezvillamor marked this conversation as resolved.
Show resolved Hide resolved
self.server = self.config.make_tableau_client(self.site_id)

@property
def site_content_url(self) -> Optional[str]:
Expand Down
Loading