Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(pgsql): Postgres doesn't support UNION select with FOR UPDATE #12169

Merged
merged 2 commits into from
Dec 19, 2024
Merged

fix(pgsql): Postgres doesn't support UNION select with FOR UPDATE #12169

merged 2 commits into from
Dec 19, 2024

Conversation

david-leifker
Copy link
Collaborator

  • Implemented a secondary method using IN vs UNION which works for both MySQL and Postgres
  • Configuration option to revert to UNION if needed

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added product PR or Issue related to the DataHub UI/UX devops PR or Issue related to DataHub backend & deployment labels Dec 18, 2024
@datahub-cyborg datahub-cyborg bot added the pending-submitter-response Issue/request has been reviewed but requires a response from the submitter label Dec 18, 2024
@david-leifker
fix(pgsql): Postgres doesn't support UNION select with FOR UPDATE
8fb6594 
* Implemented a secondary method using IN vs UNION which works for both MySQL and Postgres
* Configuration option to revert to UNION if needed
@david-leifker david-leifker force-pushed the postgres-for-update-fix branch from 4f843c2 to 8fb6594 Compare December 19, 2024 00:31
@david-leifker david-leifker merged commit 48f3cc5 into datahub-project:master Dec 19, 2024
44 of 45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RyanHolstien RyanHolstien RyanHolstien approved these changes

Assignees
No one assigned
Labels
devops PR or Issue related to DataHub backend & deployment pending-submitter-response Issue/request has been reviewed but requires a response from the submitter product PR or Issue related to the DataHub UI/UX release-0.15.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@david-leifker @RyanHolstien