Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ingest/kafka-connect): define interface for new connector impl #12149

Conversation

mayurinehate
Copy link
Collaborator

@mayurinehate mayurinehate commented Dec 17, 2024

  • Separate kafka_connect module and update setup.py
  • Split existing large file into module
    • common.py for config, report, shared data models, BaseConnector superclass for all connectors to define explicit implementations needed for new connector
    • source_connectors.py for all source connector implementations.
    • sink_connectors.py for all sink connector implementations
    • kakfa_connect.py for core control flow and aspect generation logic
  • Some minor edits - for example remove __eq__ usage

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Dec 17, 2024
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Dec 17, 2024
@datahub-cyborg datahub-cyborg bot added pending-submitter-merge and removed needs-review Label for PRs that need review from a maintainer. labels Dec 17, 2024
@mayurinehate
Copy link
Collaborator Author

CI failures are unrelated

@mayurinehate mayurinehate merged commit 953893c into datahub-project:master Dec 19, 2024
72 of 73 checks passed
yoonhyejin pushed a commit to yoonhyejin/datahub-oss-forked that referenced this pull request Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ingestion PR or Issue related to the ingestion of metadata pending-submitter-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants