Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli/properties): allow structured properties without a graph instance #12144

Merged
merged 6 commits into from
Dec 18, 2024
Merged

fix(cli/properties): allow structured properties without a graph instance #12144

merged 6 commits into from
Dec 18, 2024

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Dec 16, 2024 •
edited
Loading

  • Uses the local codegen to validate entity types instead of making a live graph call.
  • Remove the requirement of having a DataHubGraph when using StructuredProperty.
  • Adds tests to validate the structured property parsing + MCP generation.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@hsheth2
fix(cli/properties): allow structured properties without a graph inst…
6e8fb41 
…ance

This should make it a lot easier to use the StructuredProperty types.
@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Dec 16, 2024
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Dec 16, 2024
sgomezvillamor
sgomezvillamor approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@sgomezvillamor sgomezvillamor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@datahub-cyborg datahub-cyborg bot added pending-submitter-merge and removed needs-review Label for PRs that need review from a maintainer. labels Dec 17, 2024
@sgomezvillamor sgomezvillamor enabled auto-merge (squash) December 18, 2024 08:37
@sgomezvillamor sgomezvillamor merged commit 76cfac3 into master Dec 18, 2024
59 of 61 checks passed
@sgomezvillamor sgomezvillamor deleted the entity-type-validate branch December 18, 2024 09:04
hsheth2 added a commit that referenced this pull request Dec 18, 2024
@hsheth2
fix(cli/properties): fix data type validation
13b49a4 
Fixes a bug that was exposed in #12144
@hsheth2 hsheth2 mentioned this pull request Dec 18, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgomezvillamor sgomezvillamor sgomezvillamor approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata pending-submitter-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hsheth2 @sgomezvillamor