Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dataproduct): creator is assigned as owner #12127

Merged
merged 1 commit into from
Dec 13, 2024
Merged

fix(dataproduct): creator is assigned as owner #12127

merged 1 commit into from
Dec 13, 2024

Conversation

anshbansal
Copy link
Collaborator

Why?

  • If an org has owner editor policies
  • Someone goes in and creates data product in the UI, they won't be able to edit the data product that they created which is very problematic. They will have to ask overall admins to make them owner which should not be required.

Testing video https://www.loom.com/share/cb1b300112454f6cb4b61ed6b131bd1f

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the product PR or Issue related to the DataHub UI/UX label Dec 13, 2024
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Dec 13, 2024
jjoyce0510
jjoyce0510 approved these changes Dec 13, 2024
View reviewed changes
Copy link
Collaborator

@jjoyce0510 jjoyce0510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Agree this is very useful

@jjoyce0510 jjoyce0510 merged commit 50a7560 into master Dec 13, 2024
61 of 68 checks passed
@jjoyce0510 jjoyce0510 deleted the ab-dataproduct-owner branch December 13, 2024 18:01
sleeperdeep pushed a commit to sleeperdeep/datahub that referenced this pull request Dec 17, 2024
@anshbansal @sleeperdeep
fix(dataproduct): creator is assigned as owner (datahub-project#12127)
5b0e1d5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjoyce0510 jjoyce0510 jjoyce0510 approved these changes

Assignees
No one assigned
Labels
needs-review Label for PRs that need review from a maintainer. product PR or Issue related to the DataHub UI/UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anshbansal @jjoyce0510