Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingest/gc): more logging, error handling, explicit flag #12124

Merged
merged 2 commits into from
Dec 18, 2024
Merged

fix(ingest/gc): more logging, error handling, explicit flag #12124

merged 2 commits into from
Dec 18, 2024

Conversation

anshbansal
Copy link
Collaborator

@anshbansal anshbansal commented Dec 13, 2024 •
edited
Loading

  • Change so that source does not end with warnings
  • add proper enabled flags for each sub-task
  • add more error handling

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Dec 13, 2024
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Dec 13, 2024
sgomezvillamor
sgomezvillamor reviewed Dec 13, 2024
View reviewed changes
Copy link
Contributor

@sgomezvillamor sgomezvillamor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I just don't get the event_not_produced_warn field

@datahub-cyborg datahub-cyborg bot added pending-submitter-response Issue/request has been reviewed but requires a response from the submitter and removed needs-review Label for PRs that need review from a maintainer. labels Dec 13, 2024
sgomezvillamor
sgomezvillamor approved these changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@sgomezvillamor sgomezvillamor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Just left one suggestion/idea for the initialization of event_not_produced_warn

@datahub-cyborg datahub-cyborg bot added pending-submitter-merge and removed pending-submitter-response Issue/request has been reviewed but requires a response from the submitter labels Dec 13, 2024
@anshbansal
Copy link
Collaborator Author

@sgomezvillamor Taken care of your comments
@treff7es Will work on your comments. Thanks for the suggestions

@anshbansal anshbansal force-pushed the ab-add-flags-refactor branch from 16811eb to 2ccd889 Compare December 18, 2024 08:27
@anshbansal anshbansal changed the title fix(ingest/gc): refactor, add timing fix(ingest/gc): more logging, error handling, explicit flag Dec 18, 2024
@anshbansal anshbansal merged commit 2285436 into master Dec 18, 2024
71 of 73 checks passed
@anshbansal anshbansal deleted the ab-add-flags-refactor branch December 18, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@treff7es treff7es treff7es approved these changes

@sgomezvillamor sgomezvillamor sgomezvillamor approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata pending-submitter-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anshbansal @sgomezvillamor @treff7es