Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ingest/dagster): Fix Dagster build #12121

Merged
merged 4 commits into from
Dec 13, 2024
Merged

fix(ingest/dagster): Fix Dagster build #12121

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d0fb3e5
Fix Dagster build
treff7es Dec 13, 2024
cd5594a
Test for python 3.9 as well
treff7es Dec 13, 2024
c59381e
Fix linting issue
treff7es Dec 13, 2024
b38272e
Fix backard compatibility
treff7es Dec 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/dagster-plugin.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,9 @@ jobs:
DATAHUB_TELEMETRY_ENABLED: false
strategy:
matrix:
python-version: ["3.8", "3.10"]
python-version: ["3.9", "3.10"]
include:
- python-version: "3.8"
- python-version: "3.9"
extraPythonRequirement: "dagster>=1.3.3"
- python-version: "3.10"
extraPythonRequirement: "dagster>=1.3.3"
Expand Down
2 changes: 1 addition & 1 deletion metadata-ingestion-modules/dagster-plugin/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ def get_long_description():
],
# Package info.
zip_safe=False,
python_requires=">=3.8",
python_requires=">=3.9",
package_dir={"": "src"},
packages=setuptools.find_namespace_packages(where="./src"),
entry_points=entry_points,
Expand Down
6 changes: 2 additions & 4 deletions ...ta-ingestion-modules/dagster-plugin/src/datahub_dagster_plugin/sensors/datahub_sensors.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
)
from dagster._core.definitions.sensor_definition import (
DefaultSensorStatus,
RawSensorEvaluationFunctionReturn,
SensorReturnTypesUnion,
)
from dagster._core.definitions.target import ExecutableDefinition
from dagster._core.definitions.unresolved_asset_job_definition import (
Expand Down Expand Up @@ -689,9 +689,7 @@ def _emit_asset_metadata(

return SkipReason("Asset metadata processed")

def _emit_metadata(
self, context: RunStatusSensorContext
) -> RawSensorEvaluationFunctionReturn:
def _emit_metadata(self, context: RunStatusSensorContext) -> SensorReturnTypesUnion:
"""
Function to emit metadata for datahub rest.
"""
Expand Down
Loading