Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datahub-client): adds missing archiveAppendix to artifactid when publishing #12112

Conversation

sgomezvillamor
Copy link
Contributor

tested locally with publishMavenLocal

$ ./gradlew :metadata-integration:java:datahub-client:publishToMavenLocal 
...
$ ls $HOME/.m2/repository/io/acryl/datahub-client/*      
/Users/sergio/.m2/repository/io/acryl/datahub-client/maven-metadata-local.xml

/Users/sergio/.m2/repository/io/acryl/datahub-client/0.15.0rc3-SNAPSHOT:
datahub-client-0.15.0rc3-SNAPSHOT-javadoc.jar datahub-client-0.15.0rc3-SNAPSHOT-sources.jar datahub-client-0.15.0rc3-SNAPSHOT.jar         datahub-client-0.15.0rc3-SNAPSHOT.pom         maven-metadata-local.xml
$

and

$ ./gradlew clean :metadata-integration:java:datahub-client:publishToMavenLocal -PjavaClassVersionDefault=8 -ParchiveAppen         
$ ls $HOME/.m2/repository/io/acryl/datahub-client-java8/*                                                                          
/Users/sergio/.m2/repository/io/acryl/datahub-client-java8/maven-metadata-local.xml

/Users/sergio/.m2/repository/io/acryl/datahub-client-java8/0.15.0rc3-SNAPSHOT:
datahub-client-java8-0.15.0rc3-SNAPSHOT-javadoc.jar datahub-client-java8-0.15.0rc3-SNAPSHOT-sources.jar datahub-client-java8-0.15.0rc3-SNAPSHOT.jar         datahub-client-java8-0.15.0rc3-SNAPSHOT.pom         maven-metadata-local.xml
$

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Dec 12, 2024
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Dec 12, 2024
@sgomezvillamor sgomezvillamor enabled auto-merge (squash) December 12, 2024 17:50
@datahub-cyborg datahub-cyborg bot added pending-submitter-merge and removed needs-review Label for PRs that need review from a maintainer. labels Dec 12, 2024
@sgomezvillamor sgomezvillamor merged commit 613b433 into datahub-project:master Dec 12, 2024
39 of 67 checks passed
@sgomezvillamor sgomezvillamor deleted the fix-datahub-client-java8-publishing branch December 12, 2024 18:18
sleeperdeep pushed a commit to sleeperdeep/datahub that referenced this pull request Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ingestion PR or Issue related to the ingestion of metadata pending-submitter-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants