Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingest/gc): minor tweak gc source #12093

Merged
merged 1 commit into from
Dec 11, 2024
Merged

fix(ingest/gc): minor tweak gc source #12093

merged 1 commit into from
Dec 11, 2024

Conversation

anshbansal
Copy link
Collaborator

  • dataprocess_cleanup can take some time. Making it the last step so other steps get done
  • increasing hard delete entities by default from 10k to 25k

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Dec 11, 2024
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Dec 11, 2024
@datahub-cyborg datahub-cyborg bot added pending-submitter-merge and removed needs-review Label for PRs that need review from a maintainer. labels Dec 11, 2024
@anshbansal anshbansal merged commit 54d53cf into master Dec 11, 2024
95 of 128 checks passed
@anshbansal anshbansal deleted the ab-minor-tweak-gc-source branch December 11, 2024 12:54
sleeperdeep pushed a commit to sleeperdeep/datahub that referenced this pull request Dec 17, 2024
@anshbansal @sleeperdeep
fix(ingest/gc): minor tweak gc source (datahub-project#12093)
6f21420
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@treff7es treff7es treff7es approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata pending-submitter-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anshbansal @treff7es