-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ui): support all entities with display names in browse paths v2 #11657
base: master
Are you sure you want to change the base?
feat(ui): support all entities with display names in browse paths v2 #11657
Conversation
You're right - we should technically support this for any entity type. That being said, in practice Dashboards & Containers are the ones that will be in these browse paths for now |
4684cb8
to
bb8df64
Compare
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
I didn't know that there is a fragment for the entity display names...that's perfect, this is how we directly can support all entities with display names - I have adjusted it accordingly. 😊 |
@jjoyce0510 Any chance to get this one merged? |
bb8df64
to
4db2a93
Compare
As it is now supported that dashboards can contain other dashboards (#11529) it would also make sense to represent this in the browse path v2 in case a dashboard is only included in a single dashboard (same as for the charts).
Question: Shouldn't we just support all entities as part of the browse path v2 to avoid having to update the query and fragment in the future? I think technically urns of all entity types could be used as part of the browse path v2?
Checklist