Fix Dagster build

Deprecate 3.8 build
datahub-project · Dec 13, 2024 · d0fb3e5 · d0fb3e5
1 parent eef2077
commit d0fb3e5
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 6 deletions.
diff --git a/.github/workflows/dagster-plugin.yml b/.github/workflows/dagster-plugin.yml
@@ -31,10 +31,8 @@ jobs:
       DATAHUB_TELEMETRY_ENABLED: false
     strategy:
       matrix:
-        python-version: ["3.8", "3.10"]
+        python-version: ["3.10"]
         include:
-          - python-version: "3.8"
-            extraPythonRequirement: "dagster>=1.3.3"
           - python-version: "3.10"
             extraPythonRequirement: "dagster>=1.3.3"
       fail-fast: false

diff --git a/metadata-ingestion-modules/dagster-plugin/setup.py b/metadata-ingestion-modules/dagster-plugin/setup.py
@@ -123,7 +123,7 @@ def get_long_description():
     ],
     # Package info.
     zip_safe=False,
-    python_requires=">=3.8",
+    python_requires=">=3.9",
     package_dir={"": "src"},
     packages=setuptools.find_namespace_packages(where="./src"),
     entry_points=entry_points,

diff --git a/...ta-ingestion-modules/dagster-plugin/src/datahub_dagster_plugin/sensors/datahub_sensors.py b/...ta-ingestion-modules/dagster-plugin/src/datahub_dagster_plugin/sensors/datahub_sensors.py
@@ -30,7 +30,7 @@
 )
 from dagster._core.definitions.sensor_definition import (
     DefaultSensorStatus,
-    RawSensorEvaluationFunctionReturn,
+    SensorReturnTypesUnion,
 )
 from dagster._core.definitions.target import ExecutableDefinition
 from dagster._core.definitions.unresolved_asset_job_definition import (
@@ -691,7 +691,7 @@ def _emit_asset_metadata(
 
     def _emit_metadata(
         self, context: RunStatusSensorContext
-    ) -> RawSensorEvaluationFunctionReturn:
+    ) -> SensorReturnTypesUnion:
         """
         Function to emit metadata for datahub rest.
         """