fix: pr comments

datahub-project · Dec 16, 2024 · a77419e · a77419e
1 parent b9bf4eb
commit a77419e
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/metadata-ingestion/src/datahub/sql_parsing/tool_meta_extractor.py b/metadata-ingestion/src/datahub/sql_parsing/tool_meta_extractor.py
@@ -11,7 +11,7 @@
     PlatformResource,
     PlatformResourceSearchFields,
 )
-from datahub.ingestion.api.source import SourceReport
+from datahub.ingestion.api.report import Report
 from datahub.ingestion.graph.client import DataHubGraph
 from datahub.metadata.urns import CorpGroupUrn, CorpUserUrn
 from datahub.utilities.search_utils import LogicalOperator
@@ -37,8 +37,9 @@ def _get_last_line(query: str) -> str:
 
 
 @dataclass
-class ToolMetaExtractorReport(SourceReport):
+class ToolMetaExtractorReport(Report):
     num_queries_meta_extracted: Dict[str, int] = field(default_factory=int_top_k_dict)
+    failures: List[str] = field(default_factory=list)
 
 
 class ToolMetaExtractor:
@@ -91,13 +92,13 @@ def create(
             ]
 
             if platform_resources is None:
-                report.warning(
+                report.failures.append(
                     "Looker user metadata extraction failed. No Looker user id mappings found."
                 )
                 return cls()
 
             if len(platform_resources) > 1:
-                report.warning(
+                report.failures.append(
                     "Looker user metadata extraction failed. Found more than one looker user id mappings."
                 )
                 return cls()