Skip to content

Commit

Permalink
feat(globaltags to glossaryterm): add globaltags property to glossary…
Browse files Browse the repository at this point in the history
…term and glossarynode entities - fix linters
  • Loading branch information
NikEyAkube committed Dec 24, 2024
1 parent 22d8ae8 commit 0c117fd
Show file tree
Hide file tree
Showing 6 changed files with 39 additions and 39 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -102,11 +102,11 @@ class GlossaryNodeEntity implements Entity<GlossaryNode> {
{
component: SidebarOwnerSection,
},
{
{
component: SidebarTagsSection,
properties: {
hasTags: true,
hasTerms: false,
hasTerms: false,
},
},
{
Expand Down Expand Up @@ -136,7 +136,7 @@ class GlossaryNodeEntity implements Entity<GlossaryNode> {
name={this.displayName(data)}
description={data?.properties?.description || ''}
owners={data?.ownership?.owners}
globalTags={data.globalTags}
globalTags={data.globalTags}
/>
);
};
Expand All @@ -158,7 +158,7 @@ class GlossaryNodeEntity implements Entity<GlossaryNode> {
EntityCapabilityType.OWNERS,
EntityCapabilityType.DEPRECATION,
EntityCapabilityType.SOFT_DELETE,
EntityCapabilityType.TAGS
EntityCapabilityType.TAGS,
]);
};

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -125,11 +125,11 @@ export class GlossaryTermEntity implements Entity<GlossaryTerm> {
{
component: SidebarOwnerSection,
},
{
{
component: SidebarTagsSection,
properties: {
hasTags: true,
hasTerms: false,
hasTerms: false,
},
},
{
Expand Down Expand Up @@ -164,7 +164,7 @@ export class GlossaryTermEntity implements Entity<GlossaryTerm> {
description={data?.properties?.description || ''}
owners={data?.ownership?.owners}
domain={data.domain?.domain}
globalTags={data.globalTags}
globalTags={data.globalTags}
/>
);
};
Expand All @@ -190,7 +190,7 @@ export class GlossaryTermEntity implements Entity<GlossaryTerm> {
EntityCapabilityType.OWNERS,
EntityCapabilityType.DEPRECATION,
EntityCapabilityType.SOFT_DELETE,
EntityCapabilityType.TAGS
EntityCapabilityType.TAGS,
]);
};

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -51,28 +51,28 @@ export const SidebarTagsSection = ({ properties, readOnly }: Props) => {
/>
</span>
{canAddTerm && (
<>
<StyledDivider />
<span id={ENTITY_PROFILE_GLOSSARY_TERMS_ID}>
<SidebarHeader title="Glossary Terms" />
<TagTermGroup
editableGlossaryTerms={
properties?.customTermPath
? getNestedValue(entityData, properties?.customTermPath)
: entityData?.glossaryTerms
}
canAddTerm={canAddTerm}
canRemove
showEmptyMessage
entityUrn={mutationUrn}
entityType={entityType}
refetch={refetch}
readOnly={readOnly}
fontSize={12}
/>
</span>
</>
)}
<>
<StyledDivider />
<span id={ENTITY_PROFILE_GLOSSARY_TERMS_ID}>
<SidebarHeader title="Glossary Terms" />
<TagTermGroup
editableGlossaryTerms={
properties?.customTermPath
? getNestedValue(entityData, properties?.customTermPath)
: entityData?.glossaryTerms
}
canAddTerm={canAddTerm}
canRemove
showEmptyMessage
entityUrn={mutationUrn}
entityType={entityType}
refetch={refetch}
readOnly={readOnly}
fontSize={12}
/>
</span>
</>
)}
</div>
);
};
4 changes: 2 additions & 2 deletions datahub-web-react/src/graphql/glossaryNode.graphql
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,9 @@ query getGlossaryNode($urn: String!) {
forms {
...formsFields
}
globalTags {
globalTags {
...globalTagsFields
}
}
children: relationships(input: { types: ["IsPartOf"], direction: INCOMING, start: 0, count: 10000 }) {
total
relationships {
Expand Down
4 changes: 2 additions & 2 deletions datahub-web-react/src/graphql/glossaryTerm.graphql
Original file line number Diff line number Diff line change
Expand Up @@ -63,9 +63,9 @@ query getGlossaryTerm($urn: String!, $start: Int, $count: Int) {
domain {
...entityDomain
}
globalTags {
globalTags {
...globalTagsFields
}
}
institutionalMemory {
...institutionalMemoryFields
}
Expand Down
10 changes: 5 additions & 5 deletions datahub-web-react/src/graphql/search.graphql
Original file line number Diff line number Diff line change
Expand Up @@ -150,9 +150,9 @@ fragment autoCompleteFields on Entity {
... on GlossaryTerm {
name
hierarchicalName
globalTags {
globalTags {
...globalTagsFields
}
}
properties {
name
}
Expand Down Expand Up @@ -726,7 +726,7 @@ fragment searchResultsWithoutSchemaField on Entity {
parentNodes {
...parentNodesFields
}
globalTags {
globalTags {
...globalTagsFields
}
domain {
Expand All @@ -743,9 +743,9 @@ fragment searchResultsWithoutSchemaField on Entity {
parentNodes {
...parentNodesFields
}
globalTags {
globalTags {
...globalTagsFields
}
}
structuredProperties {
properties {
...structuredPropertiesFields
Expand Down

0 comments on commit 0c117fd

Please sign in to comment.