Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If statement specifying only "Wildfire" types #28

Merged
merged 8 commits into from
May 21, 2024

Conversation

vnessamartinez
Copy link
Contributor

No description provided.

@palewire
Copy link
Collaborator

palewire commented Apr 18, 2024

You want to filter out those prescribed burns? Yeah let's do it. I could see adding another commands to return the other fire types but if this is something useful to you today I say ship it.

@vnessamartinez
Copy link
Contributor Author

oh, I see what you have in mind, @palewire. I think that is a better solution. I can wait a little, so I can try that! Thank you.

@vnessamartinez
Copy link
Contributor Author

vnessamartinez commented May 2, 2024

@palewire, I made some edits and attempted to add the click commands in cli.py. Does this look right? I only added "Wildfire" and "Prescribed Fire".

@palewire
Copy link
Collaborator

palewire commented May 3, 2024

Looks great!

@vnessamartinez
Copy link
Contributor Author

Thank you for looking!

@palewire
Copy link
Collaborator

Should we cut a new release and ship it out to PyPI? I'm happy to help there.

@vnessamartinez
Copy link
Contributor Author

Let me try today to see if I can do it because I think I should learn how to do it. If I can't, I will take your offer! Thank you!

@palewire
Copy link
Collaborator

palewire commented May 21, 2024 via email

@vnessamartinez vnessamartinez merged commit 0858d5b into main May 21, 2024
10 checks passed
@vnessamartinez
Copy link
Contributor Author

Done, @palewire ! That was a lot easier than I imagined. I was looking into PyPI documentation.

@palewire
Copy link
Collaborator

palewire commented May 22, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants