Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tag filtering and speedup #88

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Added tag filtering and speedup #88

wants to merge 10 commits into from

Conversation

edurdevic
Copy link
Contributor

No description provided.

@CLAassistant
Copy link

CLAassistant commented Nov 27, 2023

CLA assistant check
All committers have signed the CLA.

discoverx/dx.py Outdated Show resolved Hide resolved
Copy link

codecov bot commented Jan 9, 2024

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (dfc9c3f) 92.90% compared to head (511f7c9) 92.40%.

Files Patch % Lines
discoverx/explorer.py 50.00% 4 Missing ⚠️
discoverx/table_info.py 87.50% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #88      +/-   ##
==========================================
- Coverage   92.90%   92.40%   -0.51%     
==========================================
  Files          11       11              
  Lines         874      895      +21     
  Branches      151      158       +7     
==========================================
+ Hits          812      827      +15     
- Misses         34       39       +5     
- Partials       28       29       +1     
Flag Coverage Δ
unittests 92.40% <76.00%> (-0.51%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zaxier
Copy link

zaxier commented Mar 11, 2024

This feature would assist my use case where a customer wants to be able to arbitrarily group tables into categories (as lists) and apply maintenance jobs based on the category. Different categories will exist side by side each other in any schema and therefore pattern based matching (without restrictive table naming conventions) won't work. A solution would be to use table tags allowing us to use patterns + table tags and keep the convenience and functionality of discoverx to operate over lists of tables.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants