-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft: Structure alignment to dblabs #110
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Migrate from setup.py
pyproject.toml
Outdated
[project] | ||
name = "databricks-labs-discoverx" | ||
dynamic = ["version"] | ||
description = 'Common libraries for Databricks Labs' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add discoverx description, not the generic one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
pyproject.toml
Outdated
dependencies = ["databricks-sdk>=0.16.0"] | ||
|
||
[project.optional-dependencies] | ||
yaml = ["PyYAML>=6.0.0,<7.0.0"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you need pyyaml?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, removed.
pyproject.toml
Outdated
"Programming Language :: Python :: 3.11", | ||
"Programming Language :: Python :: Implementation :: CPython", | ||
] | ||
dependencies = ["databricks-sdk>=0.16.0"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pyproject.toml is the new setup.py. Migrate it here
Refactored project structure to comply to Databricks Labs blueprint standard.