Fix issue with FastAPI mounts. #1183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brilee
reviewed
Feb 14, 2024
| @@ -98,7 +98,11 @@ async def __call__(self, scope: Scope, receive: Receive, send: Send) -> None: | |||
| url = URL(scope=scope).path | |||
| root_path = scope.get('root_path') or '' | |||
| ends_with_slash = ( | |||
| url.endswith('/') and url != '/' and root_path and not url.startswith(root_path + '/api') | |||
There was a problem hiding this comment.
can we make this a unit test to enumerate the kinds of URLs that this does/doesn't accept?
brilee
approved these changes
Feb 14, 2024
dsmilkov
approved these changes
Feb 14, 2024
derek-pyne
reviewed
Feb 14, 2024
|
|
||
| curl --fail --silent "http://localhost:$PORT/lilac_sub/" | ||
| curl --fail --silent "http://localhost:$PORT/$MOUNT_PATH/api/v1/tasks/" > /dev/null | ||
| curl --fail --silent "http://localhost:$PORT/$MOUNT_PATH/" --max-redirs 0 > /dev/null |
There was a problem hiding this comment.
Suggested change
| curl --fail --silent "http://localhost:$PORT/$MOUNT_PATH/" --max-redirs 0 > /dev/null | |
| curl --fail --silent "http://localhost:$PORT/$MOUNT_PATH/" -L --max-redirs 0 > /dev/null |
Need to add -L (follow redirects) for --max-redirs to have any effect
There was a problem hiding this comment.
I had to migrate this to a python test, FYI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.