Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(query): fix bug while mysql external dictionary table contains null values #16978

Merged
merged 2 commits into from
Dec 2, 2024
Merged

fix(query): fix bug while mysql external dictionary table contains null values #16978

merged 2 commits into from
Dec 2, 2024
+133 −86

Conversation

Dragonliu2018
Copy link
Contributor

@Dragonliu2018 Dragonliu2018 commented Nov 30, 2024 •
edited
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

The problem of NULL values in the table has been resolved using Option, where NULL in the table is replaced with None.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label Nov 30, 2024
@TCeason
Copy link
Collaborator

TCeason commented Dec 1, 2024

wait #16980

@sundy-li sundy-li requested a review from b41sh December 2, 2024 00:14
@Dragonliu2018 Dragonliu2018 force-pushed the dragonliu/dictionary_mysql_fix_null branch from e2ee91b to d47e600 Compare December 2, 2024 03:41
@b41sh b41sh added this pull request to the merge queue Dec 2, 2024
Merged via the queue into databendlabs:main with commit c496fce Dec 2, 2024
72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@b41sh b41sh b41sh approved these changes

Assignees
No one assigned
Labels
pr-bugfix this PR patches a bug in codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: error occurs while the mysql external dictionary table contains null
3 participants
@Dragonliu2018 @TCeason @b41sh