refactor: unify Plan and PhysicalPlan of copy into and insert #16939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
pr-refactor
# Conflicts: # src/query/service/src/interpreters/interpreter_copy_into_table.rs # src/query/service/src/interpreters/interpreter_replace.rs # src/query/service/src/pipelines/builders/builder_copy_into_table.rs # src/query/sql/src/executor/physical_plans/physical_copy_into_table.rs # src/query/sql/src/planner/binder/copy_into_table.rs # src/query/sql/src/planner/plans/copy_into_table.rs # src/query/sql/src/planner/plans/insert.rs
# Conflicts: # src/query/service/src/interpreters/interpreter_insert.rs # src/query/storages/fuse/src/operations/common/processors/sink_commit.rs
# Conflicts: # src/query/sql/src/planner/binder/copy_into_table.rs
SkyFan2002
force-pushed
the
refactor_append
branch
from
09aa29e
to
b01fe51
Compare
SkyFan2002
force-pushed
the
refactor_append
branch
from
e5f32ea
to
ba3d381
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
RelOperator::CopyIntoTableand construct the physical plan usingPhysicalPlanBuilder.CopyIntoTablePlanby removing unused fields, separating fields for commit and purge and extracting the source plan.InsertInterpreterand insert-related plans; implement insert statement by reusing CopyIntoTable logic.Tests
Type of change
This change is