fix(sqlparser): fix order by followed by scalar (#16967)

* fix(sqlparser): fix order by followed by scalar Signed-off-by: chagelo <[email protected]> * fix Signed-off-by: chagelo <[email protected]> --------- Signed-off-by: chagelo <[email protected]>
databendlabs · Dec 2, 2024 · 35c1c24 · 35c1c24
1 parent c496fce
commit 35c1c24
Show file tree

Hide file tree

Showing 2 changed files with 61 additions and 0 deletions.
diff --git a/src/query/sql/src/planner/binder/sort.rs b/src/query/sql/src/planner/binder/sort.rs
@@ -148,6 +148,10 @@ impl Binder {
                             )
                             .map_err(|e| ErrorCode::SemanticError(e.message()))?;
 
+                        if let ScalarExpr::ConstantExpr(..) = rewrite_scalar {
+                            continue;
+                        }
+
                         let column_binding =
                             if let ScalarExpr::BoundColumnRef(col) = &rewrite_scalar {
                                 col.column.clone()

diff --git a/tests/sqllogictests/suites/base/03_common/03_0004_select_order_by.test b/tests/sqllogictests/suites/base/03_common/03_0004_select_order_by.test
@@ -132,3 +132,60 @@ SELECT number FROM numbers_mt(10) ORDER BY sum(number)
 
 statement error 1065
 SELECT number FROM numbers_mt(10) ORDER BY count(*) + 1
+
+statement ok
+CREATE TABLE t1(a int, b int);
+
+statement ok
+INSERT INTO t1 VALUES(1, 3),(2, 1), (3, 2)
+
+query I
+SELECT * from t1 order by 1;
+----
+1 3
+2 1
+3 2
+
+query I
+SELECT * from t1 order by 2;
+----
+2 1
+3 2
+1 3
+
+statement error 1065
+SELECT * from t1 order by 3;
+
+query I
+SELECT * from t1 order by t1.a;
+----
+1 3
+2 1
+3 2
+
+query I
+SELECT * from t1 order by t1.b;
+----
+2 1
+3 2
+1 3
+
+statement error 1065
+SELECT * from t1 order by t1.1;
+
+query I 
+SELECT * from t1 order by 'a';
+----
+1 3
+2 1
+3 2
+
+query I 
+SELECT * from t1 order by '1', 1;
+----
+1 3
+2 1
+3 2
+
+statement ok
+DROP TABLE if EXISTS t1