Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dialect options for engine, cluster keys and transient #36

Merged
merged 1 commit into from
Apr 29, 2024
Merged

Add dialect options for engine, cluster keys and transient #36

merged 1 commit into from
Apr 29, 2024

Conversation

rad-pat
Copy link
Contributor

@rad-pat rad-pat commented Apr 26, 2024

Fixes #33
Fixes #34

@BohuTANG BohuTANG requested a review from hantmac April 27, 2024 05:12
hantmac
hantmac reviewed Apr 27, 2024
View reviewed changes
tests/test_table_options.py Outdated Show resolved Hide resolved
tests/test_table_options.py Show resolved Hide resolved
hantmac
hantmac approved these changes Apr 29, 2024
View reviewed changes
Copy link
Member

@hantmac hantmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!🚀

@hantmac hantmac merged commit 1ba5160 into databendlabs:main Apr 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hantmac hantmac hantmac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[feat] Support Transient Table in dialect [feat] Support Cluster By in Table Create
2 participants
@rad-pat @hantmac