[PLUGIN-1832] Error Management Snowflake Source and Sink, fix sonar issues, and added new Validation and fix bugs for maximum split size and NPE issue handled #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| String errorMessageFormat = "Error occurred in the phase: '%s'. Error message: %s"; | ||
| return ErrorUtils.getProgramFailureException(new ErrorCategory(ErrorCategory.ErrorCategoryEnum.PLUGIN), | ||
| errorMessage, | ||
| String.format(errorMessageFormat, errorContext.getPhase(), errorMessage), ErrorType.SYSTEM, false, e); |
There was a problem hiding this comment.
can you please provide rationale as comment, why all these exceptions are considered as SYSTEM error?
There was a problem hiding this comment.
I did not ask to convert them to USER, question was to provide why these are marked as SYSTEM errors?
There was a problem hiding this comment.
URISyntaxException is not being thrown in this plugin, i think we can remove this case.
For classification all error due to user input can be classified as USER
…for maximum split size and NPE issue handled
Amit-CloudSufi
force-pushed
the
snowFlakeError
branch
from
1fd1285 to
756fb99
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIra : https://cdap.atlassian.net/browse/PLUGIN-1832