Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cherrypick][PLUGIN-1809]Fix added to override schema #35

Conversation

vikasrathee-cs
Copy link
Contributor

@vikasrathee-cs vikasrathee-cs commented Oct 1, 2024

[cherrypick][PLUGIN-1809] Fix added to override schema

cherrypick #33, #34

@vikasrathee-cs vikasrathee-cs changed the title [cherrypick][[PLUGIN-1809]]Fix added to override schema [cherrypick][PLUGIN-1809]Fix added to override schema Oct 1, 2024
@vikasrathee-cs vikasrathee-cs added the build build label Oct 1, 2024
Copy link
Member

@itsankit-google itsankit-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also cherry-pick: #34 so that we can ensure build is passing.

@itsankit-google
Copy link
Member

The unit test build is failing, please update cdap & hydrator dependency version to 6.1.4 & 2.3.4 respectively:

<cdap.version>6.1.0-SNAPSHOT</cdap.version>
<hydrator.version>2.3.0-SNAPSHOT</hydrator.version>

@vikasrathee-cs vikasrathee-cs force-pushed the override-schema-release branch from d06742f to 53d66fb Compare October 1, 2024 13:23
@itsankit-google
Copy link
Member

Looks like the build is still failing, can you try updating the cdap & hydrator dependency to more recent one:

6.4.1 & 2.6.1 respectively.

Please also update the lower bound for parents accordingly:

snowflake-plugins/pom.xml

Lines 401 to 402 in bc1a68c

<parent>system:cdap-data-pipeline[6.1.0-SNAPSHOT,7.0.0-SNAPSHOT)</parent>
<parent>system:cdap-data-streams[6.1.0-SNAPSHOT,7.0.0-SNAPSHOT)</parent>

Added unit test cases flow for build and fixes junits
@vikasrathee-cs vikasrathee-cs merged commit 82b77d1 into data-integrations:release/1.1 Oct 3, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants