Servicenow Code refactor #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrRahulSharma
changed the title
MrRahulSharma
force-pushed
the
refactor/LimitingCallsToCreateAccessToken
branch
from
15c1127 to
c7f4eb7
Compare
vanathi-g
approved these changes
Mar 13, 2024
...e2e-test/java/io/cdap/plugin/servicenowsink/actions/ServiceNowSinkPropertiesPageActions.java
Show resolved
Hide resolved
src/main/java/io/cdap/plugin/servicenow/source/ServiceNowRecordReader.java
Outdated
Show resolved
Hide resolved
The failure is due to some data missing from the salesforce setup. Will work on fixing this with Cloudsufi. |
MrRahulSharma
force-pushed
the
refactor/LimitingCallsToCreateAccessToken
branch
from
009268b to
d2c07c4
Compare
CuriousVini
added a commit
that referenced
this pull request
Mar 14, 2024
This reverts commit aeb9d2f.
MrRahulSharma
added a commit
that referenced
this pull request
Apr 26, 2024
MrRahulSharma
pushed a commit
that referenced
this pull request
Apr 26, 2024
This reverts commit aeb9d2f.
MrRahulSharma
added a commit
that referenced
this pull request
Apr 26, 2024
* Validate Http Response * Api refactoring (#68) * Servicenow code refactor and E2E test fix (#71) * Revert "Servicenow code refactor and E2E test fix (#71)" This reverts commit aeb9d2f. * Revert "Revert "Servicenow Code refactor"" (#73) --------- Co-authored-by: Sai Aditya Mukkamala <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.