[PLUGIN-1817] Added check for non-spreadsheet files with proper error. #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vikasrathee-cs
force-pushed
the
sheets-filetype-check-dev
branch
from
ea22c34 to
a9350a4
Compare
vikasrathee-cs
changed the title
vikasrathee-cs
force-pushed
the
sheets-filetype-check-dev
branch
from
a9350a4 to
a466d9d
Compare
src/main/java/io/cdap/plugin/google/common/APIRequestRetryer.java
Outdated
Show resolved
Hide resolved
MrRahulSharma
approved these changes
Nov 13, 2024
vikasrathee-cs
force-pushed
the
sheets-filetype-check-dev
branch
from
a466d9d to
4211294
Compare
src/main/java/io/cdap/plugin/google/common/GoogleDriveFilteringClient.java
Outdated
Show resolved
Hide resolved
itsankit-google
previously requested changes
Nov 19, 2024
vikasrathee-cs
force-pushed
the
sheets-filetype-check-dev
branch
from
4211294 to
363f490
Compare
itsankit-google
approved these changes
Nov 19, 2024
src/main/java/io/cdap/plugin/google/common/GoogleDriveFilteringClient.java
Outdated
Show resolved
Hide resolved
vikasrathee-cs
force-pushed
the
sheets-filetype-check-dev
branch
2 times, most recently
from
0069f97 to
757c205
Compare
src/main/java/io/cdap/plugin/google/common/APIRequestRetryer.java
Outdated
Show resolved
Hide resolved
src/main/java/io/cdap/plugin/google/common/APIRequestRetryer.java
Outdated
Show resolved
Hide resolved
vikasrathee-cs
force-pushed
the
sheets-filetype-check-dev
branch
from
757c205 to
e707a6e
Compare
itsankit-google
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PLUGIN-1817 Added check for non-spreadsheet files with proper error.
Google Sheets Plugin throws ‘This operation is not supported for this document’ for xls format.
Google Sheets Plugin throws ‘Request contains an invalid argument’ for csv/pdf/doc file format.
Add a proper error mentioning it is not a google spreadsheet file.