PLUGIN-1438: Added support for destination table write preference in BQ Execute Plugin #1473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anshumanks
changed the title
There was a problem hiding this comment.
Please add evidence/screenshots in PR description under Tested section.
A good PR description example: #1444 (comment)
Comment on lines
406
to
409
| @Description("Specifies the write preference for the destination table. Options are: " + | ||
| "Write if Empty: Only write if the table is empty. " + | ||
| "Append to Table: Add results to existing data. " + | ||
| "Overwrite Table: Replace all existing data.") |
There was a problem hiding this comment.
Description/Tooltip should be crisp: Specifies whether a job should overwrite or append the existing destination table if it already exists.
Please add these details in markdown: https://github.com/data-integrations/google-cloud/blob/develop/docs/BigQueryExecute-action.md
src/main/java/io/cdap/plugin/gcp/bigquery/action/BigQueryExecute.java
Outdated
Show resolved
Hide resolved
src/main/java/io/cdap/plugin/gcp/bigquery/action/BigQueryExecute.java
Outdated
Show resolved
Hide resolved
src/test/java/io/cdap/plugin/gcp/bigquery/action/BigQueryExecuteTest.java
Outdated
Show resolved
Hide resolved
anshumanks
force-pushed
the
bigQuery-Execute-Plugin
branch
2 times, most recently
from
40b5f74 to
d7b5253
Compare
…ugin Addressed PR comments: updated description, added documentation for the added feature Formatted to fix failing tests Refactor: Replace hardcoded write preference strings with JobInfo.WriteDisposition constants Refactor: Simplify error message for invalid write preference validation Refactor: Centralize valid write preferences in BigQueryExecute.Config Refactor: Dynamically generate valid write preferences from JobInfo.WriteDisposition
anshumanks
force-pushed
the
bigQuery-Execute-Plugin
branch
from
d7b5253 to
a467a7a
Compare
itsankit-google
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for destination table write preference in BQ Execute Plugin
Jira : PLUGIN-1438
Description
This update introduces the ability for users to select a destination table write preference when storing results in BigQuery. Users can now choose from the following options:
UI Field
BigQueryExecute-action.jsonDocs
BigQueryExecute-action.mdCode change
BigQueryExecute.javaUnit Tests
BigQueryExecuteTest.javaTested