GCS cloudbuild e2e fixes #1462
GCS cloudbuild e2e fixes #1462
Conversation
AnkitCLI
force-pushed
the
GCS-cloudbuild-fixes
branch
from
bc9242b to
844e322
Compare
AnkitCLI
force-pushed
the
GCS-cloudbuild-fixes
branch
from
844e322 to
527e4e6
Compare
added the step for both scenarios. |
| Then Open Pipeline logs and verify Log entries having below listed Level and Message: | ||
| | Level | Message | | ||
| | ERROR | errorMessageMultipleFileWithFirstRowAsHeaderEnabled | | ||
| | WARN | errorMessageMultipleFileWithFirstRowAsHeaderEnabled | |
There was a problem hiding this comment.
how is this WARN?
I can see the level is ERROR:
How is this test passing right now?
There was a problem hiding this comment.
Basically to make it compatible with both cdap and CDF we use warn here because in cdap it only show NumberFormatException error in only WARN level in advanced logs. You are checking it in raw logs. But the above mentioned step only checks in advanced logs section.
There was a problem hiding this comment.
Can we modify the step to check in raw logs? So that it is consistent in both cdap and CDF.
There was a problem hiding this comment.
Changed it to the common errorMessage for both cdap and CDF in ERROR level.
AnkitCLI
force-pushed
the
GCS-cloudbuild-fixes
branch
from
527e4e6 to
697b995
Compare
AnkitCLI
force-pushed
the
GCS-cloudbuild-fixes
branch
from
697b995 to
52dbbfe
Compare
itsankit-google
merged commit 692dfcd
into
data-integrations:develop
This PR contains fix for the error message mismatch for GCS on cloudbuild