[CDAP-21093] Add ExternalDocumentationLink in abstract sink #533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psainics
force-pushed
the
patch/absink-getExternalDocumentationLink
branch
from
c1663bf to
2018b92
Compare
psainics
force-pushed
the
patch/absink-getExternalDocumentationLink
branch
from
2018b92 to
08ccb27
Compare
psainics
force-pushed
the
patch/absink-getExternalDocumentationLink
branch
from
08ccb27 to
5952ef7
Compare
sahusanket
reviewed
Dec 27, 2024
| throw ErrorUtils.getProgramFailureException(new ErrorCategory(ErrorCategory.ErrorCategoryEnum.PLUGIN), | ||
| e.getMessage(), errorMessageWithDetails, ErrorType.USER, false, ErrorCodeType.SQLSTATE, | ||
| e.getSQLState(), externalDocumentationLink, new SQLException(e.getMessage(), | ||
| e.getSQLState(), e.getErrorCode())); |
There was a problem hiding this comment.
This is auto formatted, with extra intendation since e.getSQLState(), e.getErrorCode()) is part of nested function call to new SQLException
sahusanket
reviewed
Dec 27, 2024
| * Override this method to provide a custom external documentation link. | ||
| * | ||
| * @return external documentation link | ||
| */ | ||
| protected String getExternalDocumentationLink() { |
There was a problem hiding this comment.
I think we should make this abstract and enforce the child to implement it correctly.
Returning null might cause issue if someone misses to override this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ExternalDocumentationLink in abstract sink
Jira : CDAP-21093
Description
The AbstractDBSink class also throw SQLException, we also need to make the changes similar to AbstractDBSource there as well.
Ref: #530
Code change
CloudSQLMySQLSink.javaCloudSQLPostgreSQLSink.javaAbstractDBSink.javaAbstractDBSource.javaMysqlSink.javaPostgresSink.java