Skip to content

Commit

Permalink
Merge pull request #459 from data-integrations/PLUGIN-1681
Browse files Browse the repository at this point in the history
[PLUGIN-1681] Add macro support back for database config in postgres connector
  • Loading branch information
itsankit-google authored Sep 13, 2023
2 parents 36961f1 + 717220b commit 82a8feb
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ Feature: PostgreSQL source- Verify PostgreSQL source plugin design time macro sc
Then Click on the Macro button of Property: "user" and set the value to: "postGreSQLUser"
Then Click on the Macro button of Property: "password" and set the value to: "postGreSQLPassword"
Then Click on the Macro button of Property: "connectionArguments" and set the value to: "postGreSQLConnectionArguments"
Then Replace input plugin property: "database" with value: "databaseName"
Then Click on the Macro button of Property: "database" and set the value to: "postGreSQLDatabase"
Then Enter input plugin property: "referenceName" with value: "sourceRef"
Then Enter textarea plugin property: "importQuery" with value: "selectQuery"
Then Validate "PostgreSQL" plugin properties
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
package io.cdap.plugin.postgres;

import io.cdap.cdap.api.annotation.Description;
import io.cdap.cdap.api.annotation.Macro;
import io.cdap.cdap.api.annotation.Name;
import io.cdap.plugin.db.connector.AbstractDBSpecificConnectorConfig;

Expand All @@ -38,6 +39,7 @@ public PostgresConnectorConfig(String host, int port, String user, String passwo

@Name(NAME_DATABASE)
@Description("Database to connect to.")
@Macro
private String database;

@Override
Expand Down

0 comments on commit 82a8feb

Please sign in to comment.