Review Comments

data-integrations · Jan 2, 2024 · 79e58f2 · 79e58f2
1 parent 3a53fc9
commit 79e58f2
Showing 1 changed file with 8 additions and 6 deletions.
diff --git a/oracle-plugin/src/main/java/io/cdap/plugin/oracle/OracleConstants.java b/oracle-plugin/src/main/java/io/cdap/plugin/oracle/OracleConstants.java
@@ -16,6 +16,8 @@
 
 package io.cdap.plugin.oracle;
 
+import javax.annotation.Nullable;
+
 /**
  * Oracle Constants.
  */
@@ -47,17 +49,17 @@ private OracleConstants() {
    * @return Connection String based on the given ConnectionType
    */
   public static String getConnectionString(String connectionType,
-                                           String host,
-                                           int port,
+                                           @Nullable String host,
+                                           @Nullable int port,
                                            String database) {
     if (OracleConstants.TNS_CONNECTION_TYPE.equalsIgnoreCase(connectionType)) {
       return String.format(OracleConstants.ORACLE_CONNECTION_STRING_TNS_FORMAT, database);
-    } else if (OracleConstants.SERVICE_CONNECTION_TYPE.equalsIgnoreCase(connectionType)) {
+    }
+    if (OracleConstants.SERVICE_CONNECTION_TYPE.equalsIgnoreCase(connectionType)) {
       return String.format(OracleConstants.ORACLE_CONNECTION_STRING_SERVICE_NAME_FORMAT,
           host, port, database);
-    } else {
-      return String.format(OracleConstants.ORACLE_CONNECTION_STRING_SID_FORMAT,
-          host, port, database);
     }
+    return String.format(OracleConstants.ORACLE_CONNECTION_STRING_SID_FORMAT,
+        host, port, database);
   }
 }