Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: add create_diagonal #19

Merged
merged 6 commits into from
Nov 18, 2024
Merged

Conversation

lucascolley
Copy link
Collaborator

Closes gh-15

@lucascolley lucascolley added enhancement New feature or request new function labels Nov 14, 2024
@lucascolley lucascolley marked this pull request as ready for review November 14, 2024 19:22
@lucascolley
Copy link
Collaborator Author

any comments appreciated @j-bowhay @mdhaber !

Copy link
Contributor

@j-bowhay j-bowhay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation looks good, a couple of questions around the tests

tests/test_funcs.py Outdated Show resolved Hide resolved
tests/test_funcs.py Show resolved Hide resolved
Copy link
Contributor

@j-bowhay j-bowhay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@lucascolley
Copy link
Collaborator Author

rendered docs look good to me, thanks for the review Jake!

@lucascolley lucascolley merged commit 34db8df into data-apis:main Nov 18, 2024
7 checks passed
@lucascolley lucascolley deleted the diagonal branch November 18, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request new function
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ENH: creating a diagonal array
2 participants