Add support for NumPy 2.0 #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
This is a change from data-apis#76.
|
OK, it looks like this is working. This is ready for review. Then I can double check the cupy tests and cut a release. |
|
Two CI failures:
|
rgommers
approved these changes
Jan 18, 2024
numpy-dev-xfails.txt
Outdated
| array_api_tests/test_has_names.py::test_has_names[array_attribute-device] | ||
|
|
||
| # linalg tests require https://github.com/data-apis/array-api-tests/pull/101 | ||
| # cleanups. Also some tests are using .mT |
There was a problem hiding this comment.
ndarray.mT exists now. not sure if this test still needs skipping, or only this part of the comment needs to be removed?
numpy-dev-xfails.txt
Outdated
|
|
||
| # Array methods and attributes not already on np.ndarray cannot be wrapped | ||
| array_api_tests/test_signatures.py::test_array_method_signature[__array_namespace__] | ||
| array_api_tests/test_signatures.py::test_array_method_signature[to_device] |
There was a problem hiding this comment.
About to land: numpy/numpy#25233
numpy-dev-xfails.txt
Outdated
| array_api_tests/test_linalg.py::test_solve | ||
|
|
||
| # Array methods and attributes not already on np.ndarray cannot be wrapped | ||
| array_api_tests/test_signatures.py::test_array_method_signature[__array_namespace__] |
There was a problem hiding this comment.
This method exists already for a few weeks, and I just merged what's probably the fix to make this test pass: numpy/numpy#25595
|
I guess the nightly builds are lagged. Going to just merge this now to avoid further delay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #77