Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add newaxis to torch aliases #66

Merged
merged 1 commit into from
Nov 14, 2023
Merged

Conversation

rgommers
Copy link
Member

@rgommers rgommers commented Nov 9, 2023

Closes gh-64

@rgommers
Copy link
Member Author

rgommers commented Nov 9, 2023

Will add a corresponding test case to array-api_tests as well (see data-apis/array-api-tests#198).

@asmeurer
Copy link
Member

asmeurer commented Nov 9, 2023

Looks good. Merging might be blocked on #65 though.

@rgommers
Copy link
Member Author

This was green before, and gh-65 is unrelated and should not be blocking. No idea why the fft tests are failing now, probably another case of "should use derandomize". Either way, let's merge this?

@asmeurer
Copy link
Member

We'll have to fix the CI before we release at least.

@asmeurer asmeurer merged commit 12859ce into data-apis:main Nov 14, 2023
7 of 18 checks passed
@rgommers rgommers deleted the add-torch-newaxis branch November 15, 2023 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AttributeError: module 'array_api_compat.torch' has no attribute 'newaxis'
2 participants