Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conjugate the first argument in vecdot #201

Merged
merged 2 commits into from
Nov 20, 2024
Merged

Conjugate the first argument in vecdot #201

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
07043a0
Conjugate the first argument in vecdot
asmeurer Nov 19, 2024
89a85a6
Merge branch 'main' into vecdot-conj
asmeurer Nov 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion array_api_compat/common/_aliases.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -479,7 +479,7 @@ def vecdot(x1: ndarray, x2: ndarray, /, xp, *, axis: int = -1) -> ndarray:
x2_ = xp.moveaxis(x2, axis, -1)
x1_, x2_ = _broadcast(x1_, x2_)

res = x1_[..., None, :] @ x2_[..., None]
res = xp.conj(x1_[..., None, :]) @ x2_[..., None]
ev-br marked this conversation as resolved.
Show resolved Hide resolved
return res[..., 0, 0]

# isdtype is a new function in the 2022.12 array API specification.
Expand Down
Loading