Re-enable wrapping unconditionally for NumPy #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NumPy 2.0 and 2.1 both have some incompatibilities with the array API (see data-apis#167 and data-apis#164). Closes data-apis#168.
|
For now I'm going to just use the full wrappers for all versions of NumPy. This is actually what the CI has been testing all along. However, we might consider using a much reduced wrapper for NumPy 2.0+, especially if it can make a difference for performance. |
lucascolley
reviewed
Aug 2, 2024
There was a problem hiding this comment.
I think you need to adjust
array-api-compat/tests/_helpers.py
Lines 6 to 10 in 158622e
This was referenced Oct 8, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NumPy 2.0 and 2.1 both have some incompatibilities with the array API (see
#167 and #164).
Closes #168.