Don't wrap NumPy 2.0 at all #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If None, it does the default behavior. If True or False it forces the use or non-use of the compat wrapper. This commit also changes it so that NumPy 2.0 does not return the wrapper library at all by default (when use_compat=None), since it is completely array API compatible on its own.
NumPy 2.0 no longer uses the wrapper code at all (unless explicitly requested with array_namespace(use_compat=True), but this is not really supported).
|
Note that I'm still running the test suite against numpy 2.0, as I want to make sure that if at any point in the future wrapping becomes necessary again that I am made aware of that. |
|
This is ready to go. Once we start supporting 2023.12, we'll probably have to add a wrapper again, if just for the new inspection APIs. My guess is that if/when that happens we'll want to have a separate wrapper namespace for NumPy 2.0 because the rest of the NumPy 1.26 wrapper functions are pointless to use with 2.0. Maybe at that point we can reuse whatever solution I come up with for data-apis/array-api-strict#8 to streamline this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also adds a
use_compatflag toarray_namespace. If None, it does the default behavior. If True or False it forces the use ornon-use of the compat wrapper.
Tests will fail here until data-apis/array-api-strict#24 is released.