-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for 2023.12 #127
Comments
@leofang I'm looking at implementing the inspection APIs for CuPy https://data-apis.org/array-api/latest/API_specification/inspection.html. I have some questions:
Unfortunately, while I do have a CUDA GPU, I don't currently have a machine with more than one to test this stuff on. |
I'm not sure if all the details here are correct. See data-apis#127 (comment).
I implemented something at https://github.com/data-apis/array-api-compat/pull/166/files#diff-c81a58c37b983a1eea2b7fcc43f23c8c769acac5e6d0cf1763e9a3964568c035, but I made some assumptions about the answers to the above questions. |
Looking at PyTorch, there are some questions that arise for inspection APIs:
|
|
I'd say we can close this. If we run into more issues as we update the test suite, we can fix them. |
This is a tracking issue for 2023.12 support in array-api-compat.
The list of changes for 2023.12 is at https://data-apis.org/array-api/latest/changelog.html#v2023-12
Currently, we don't have test suite support for 2023.12 (data-apis/array-api-tests#249), so it's hard to implement full support. However, if there are any known differences for a given library and 2023.12, we can implement a wrapper for them, especially if this is blocking anyone's real world usage. Please comment below if this is the case for you.
Note that any function that is already implemented in upstream libraries will already work with array-api-compat, since it only extends the existing library namespaces. So this is only necessary if some upstream function or behavior is different from what is written in the 2023.12 standard.
Here is the checklist of functions (from data-apis/array-api-tests#249):
Here is the list of changes https://data-apis.org/array-api/latest/changelog.html#v2023-12
New Functions
__array_namespace_info__
(i.e., the inspection API)clip
(not implemented for dask, as the wrapper implementation uses mask assignment)copysign
cumulative_sum
hypot
maximum
minimum
moveaxis
repeat
searchsorted
signbit
tile
unstack
API Changes
device
keyword added toastype
(won't be wrapped)from_dlpack
requires exceptions in some cases(won't be wrapped)copy
anddevice
keywords tofrom_dlpack
sum
,prod
,trace
output dtype change (Update dtype assertions in sum-like tests for>2023.12
versions array-api-tests#234)Other Changes
tensordot
should support negative axesThe text was updated successfully, but these errors were encountered: