Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maximum does not seem to work with cupy.array_api #160

Closed
OmarManzoor opened this issue Jul 11, 2024 · 5 comments
Closed

maximum does not seem to work with cupy.array_api #160

OmarManzoor opened this issue Jul 11, 2024 · 5 comments

Comments

@OmarManzoor
Copy link

It seems that the function maximum is currently not available for cupy.array_api. It is present in the array api specification maximum and works for the other apis. Could this be made compatible for cupy.array_api as well?

@lucascolley
Copy link
Contributor

Hey @OmarManzoor , this is a duplicate of gh-127. maximum was added to the standard in the 2023.12 version, and work on that is still in progress.

@OmarManzoor
Copy link
Author

@lucascolley Thanks for the feedback!

@asmeurer
Copy link
Member

asmeurer commented Jul 15, 2024

What version of CuPy are you using? cupy has the maximum function https://docs.cupy.dev/en/latest/reference/generated/cupy.maximum.html. array_api_compat.cupy is just an extension of what is already in cupy, so if something is already in cupy there is nothing to do here.

Note that there is a difference between array_api_compat (this repo) and cupy.array_api. cupy.array_api is the cupy version of numpy.array_api, which has been removed from numpy in NumPy 2.0 and renamed to array-api-strict. cupy.array_api should not be used, unless you specifically need to test array API strictness with device support (see also data-apis/array-api-strict#5).

@asmeurer
Copy link
Member

This may also be useful to understand the difference https://data-apis.org/array-api-compat/#difference-between-array-api-compat-and-array-api-strict

@OmarManzoor
Copy link
Author

Thank you for the clarifications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants