test: working test vector for withdrawals

dashpay · Jan 4, 2024 · 77eaa48 · 77eaa48
1 parent 1757ecc
commit 77eaa48
Showing 1 changed file with 26 additions and 36 deletions.
diff --git a/types/quorum_sign_data_test.go b/types/quorum_sign_data_test.go
@@ -124,68 +124,58 @@ func TestMakeVoteExtensionSignsData(t *testing.T) {
 }
 
 // TestVoteExtensionsRawSignData checks signed data for a VoteExtensionType_THRESHOLD_RECOVER_RAW vote extension type.
+// It uses test vectors from withdrawal processing.
 //
 // Given some vote extension, llmq type, quorum hash and sign request id, sign data should match predefined test vector.
-func TestVoteExtensionsRawSignDataRawVector(t *testing.T) {
-	// t.Skip("TODO: this should use the same test vectors as dash core")
+func TestVoteExtensionsRawSignDataRawVector_Withdrawals(t *testing.T) {
+	// llmqType:106
+	// quorumHash:53c006055af6d0ae9aa9627df8615a71c312421a28c4712c8add83c8e1bfdadd
+	// requestID:922a8fc39b6e265ca761eaaf863387a5e2019f4795a42260805f5562699fd9fa
+	// messageHash:2a3b788b83a8a3877d618874c0987ce62b43762ea18362cd336f4a79402d25c0
+	// ==== signHash:9753911839e0a8304626b95ada276b55a3785bca657294a153bd5d66301756b7
+
 	const chainID = "some-chain"
 	const llmqType = btcjson.LLMQType_TEST_PLATFORM
 
-	// threshold_vote_extensions: [VoteExtension { r#type: ThresholdRecoverRaw,
-	//  signature: [172, 4, 13, 160, 146, 213, 36, 188, 135, 233, 210, 83, 219, 136, 137, 56, 239, 214, 169, 192, 230, 76, 12, 129, 225, 221, 226, 53, 121, 4, 208, 206, 187, 5, 189, 177, 153, 248, 113, 211, 48, 64, 106, 119, 168, 92, 231, 199, 12, 225, 210, 227, 198, 53, 89, 178, 166, 144, 35, 58, 74, 230, 154, 60, 86, 193, 197, 113, 24, 92, 119, 211, 31, 50, 175, 139, 63, 182, 1, 236, 181, 55, 183, 240, 70, 101, 152, 134, 17, 45, 17, 107, 81, 112, 101, 3],
-	//   sign_request_id: Some([6, 112, 108, 119, 100, 116, 120, 0, 0, 0, 0, 0, 0, 0, 0]) }] }
-
-	// TODO
-	// quorumHash, err := hex.DecodeString("dddabfe1c883dd8a2c71c4281a4212c3715a61f87d62a99aaed0f65a0506c053")
-	// assert.NoError(t, err)
-	// assert.Len(t, quorumHash, 32)
-
-	// requestID, err := hex.DecodeString("922a8fc39b6e265ca761eaaf863387a5e2019f4795a42260805f5562699fd9fa")
-	// assert.NoError(t, err)
-	// assert.Len(t, requestID, 32)
-
-	// extension, err := hex.DecodeString("7dfb2432d37f004c4eb2b9aebf601ba4ad59889b81d2e8c7029dce3e0bf8381c")
-	// assert.NoError(t, err)
-	// assert.Len(t, extension, 32)
-	quorumHash, err := hex.DecodeString("1cdbea29c8b947d6a35269aabbd0cccfef64245778a62116524ccdbb6e3ec919")
+	quorumHash, err := hex.DecodeString("53c006055af6d0ae9aa9627df8615a71c312421a28c4712c8add83c8e1bfdadd")
 	assert.NoError(t, err)
 	assert.Len(t, quorumHash, 32)
 
-	assert.NoError(t, err)
-
-	extension := []byte{209, 226, 137, 236, 75, 102, 97, 95, 224, 61, 203, 233, 87, 62, 153, 90, 177, 26, 169, 127, 239, 22, 141, 238, 175, 198, 120, 8, 156, 150, 182, 166}
-	assert.Len(t, extension, 32)
-
+	extension := []byte{192, 37, 45, 64, 121, 74, 111, 51, 205, 98, 131, 161, 46, 118, 67, 43, 230, 124, 152, 192, 116, 136, 97, 125, 135, 163, 168, 131, 139, 120, 59, 42}
 	requestID := []byte{6, 112, 108, 119, 100, 116, 120, 0, 0, 0, 0, 0, 0, 0, 0}
-	signature := []byte{172, 4, 13, 160, 146, 213, 36, 188, 135, 233, 210, 83, 219, 136, 137, 56, 239, 214, 169, 192, 230, 76, 12, 129, 225, 221, 226, 53, 121, 4, 208, 206, 187, 5, 189, 177, 153, 248, 113, 211, 48, 64, 106, 119, 168, 92, 231, 199, 12, 225, 210, 227, 198, 53, 89, 178, 166, 144, 35, 58, 74, 230, 154, 60, 86, 193, 197, 113, 24, 92, 119, 211, 31, 50, 175, 139, 63, 182, 1, 236, 181, 55, 183, 240, 70, 101, 152, 134, 17, 45, 17, 107, 81, 112, 101, 3}
+	// assert.Len(t, requestID, 32)
+
+	expectedSignHash, err := hex.DecodeString("9753911839e0a8304626b95ada276b55a3785bca657294a153bd5d66301756b7")
+	assert.NoError(t, err)
+	assert.Len(t, expectedSignHash, 32)
+	expectedSignHash = tmbytes.Reverse(expectedSignHash)
 
-	expected, err := hex.DecodeString("B7561730665DBD53A1947265CA5B78A3556B27DA5AB9264630A8E03918915397")
+	expectedRequestID, err := hex.DecodeString("922a8fc39b6e265ca761eaaf863387a5e2019f4795a42260805f5562699fd9fa")
 	assert.NoError(t, err)
-	assert.Len(t, expected, 32)
-	// expected = tmbytes.Reverse(expected)
+	assert.Len(t, expectedRequestID, 32)
 
 	// Note: MakeVoteExtensionSignItems() calls MakeSignID(), which will reverse bytes in quorumHash, requestID and extension.
 
-	ve := VoteExtensionFromProto(tmproto.VoteExtension{
+	ve := tmproto.VoteExtension{
 		Extension: extension,
-		Signature: signature,
+		Signature: []byte{},
 		Type:      tmproto.VoteExtensionType_THRESHOLD_RECOVER_RAW,
 		XSignRequestId: &tmproto.VoteExtension_SignRequestId{
 			SignRequestId: requestID,
 		},
-	})
-
-	item, err := ve.SignItem(chainID, 1, 0, llmqType, quorumHash)
+	}
+	voteExtension := VoteExtensionFromProto(ve)
+	signItem, err := voteExtension.SignItem(chainID, 1, 0, llmqType, quorumHash)
 	assert.NoError(t, err)
-	actual := item.SignHash
 
 	t.Logf("LLMQ type: %s (%d)\n", llmqType.Name(), llmqType)
 	t.Logf("extension: %X\n", extension)
 	t.Logf("sign requestID: %X\n", requestID)
 	t.Logf("quorum hash: %X\n", quorumHash)
 
-	t.Logf("RESULT: signHash: %X", actual)
-	assert.EqualValues(t, expected, actual)
+	t.Logf("RESULT: sign hash: %X", signItem.SignHash)
+	assert.EqualValues(t, expectedSignHash, signItem.SignHash)
+	assert.EqualValues(t, expectedRequestID, signItem.ID)
 
 }