fix(consensus): we should panic if finalize block on apply commit fai…

…ls (#966)

* fix(consensus): we should panic on apply commit

* build(github): lint only new issues

* chore: update mocks

.github/workflows/lint.yml

@@ -56,4 +56,5 @@ jobs:
           version: v1.61
           args: --timeout 10m
           github-token: ${{ secrets.github_token }}
+          only-new-issues: true
         if: env.GIT_DIFF

internal/consensus/state_apply_commit.go

@@ -79,7 +79,9 @@ func (c *ApplyCommitAction) Execute(ctx context.Context, stateEvent StateEvent)
 	stateCopy, err := c.blockExec.finalize(ctx, stateData, commit)
 	if err != nil {
 		c.logger.Error("failed to apply block", "err", err)
-		return nil
+		// If something went wrong within ABCI client, it can stop and we can't recover from it.
+		// So, we panic here to ensure that the node will be restarted.
+		panic(fmt.Errorf("failed to finalize block %X at height %d: %w", block.Hash(), block.Height, err))
 	}
 
 	lastBlockMeta := c.blockStore.LoadBlockMeta(height - 1)

internal/state/execution.go

@@ -763,13 +763,7 @@ func execBlockWithoutState(
 	commit *types.Commit,
 	logger log.Logger,
 ) (*abci.ResponseFinalizeBlock, error) {
-	respFinalizeBlock, err := execBlock(ctx, appConn, block, commit, logger)
-	if err != nil {
-		logger.Error("executing block", "err", err)
-		return respFinalizeBlock, err
-	}
-
-	return respFinalizeBlock, nil
+	return execBlock(ctx, appConn, block, commit, logger)
 }
 
 func (blockExec *BlockExecutor) pruneBlocks(retainHeight int64) {