Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: State sync APIs should use encoded Ops #297

Merged
merged 5 commits into from
May 13, 2024
Merged

Conversation

ogabrielides
Copy link
Collaborator

@ogabrielides ogabrielides commented May 13, 2024

Issue being fixed or feature implemented

Platform ABCI isn't aware of Ops structure. Therefore, grovedb state sync related APIs should always use encoded into bytes ops.

What was done?

Wrote utility functions util_encode_vec_ops and util_decode_vec_ops and adjusted fetch_chunk and apply_chunk.

How Has This Been Tested?

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@ogabrielides ogabrielides merged commit 65a7512 into develop May 13, 2024
7 checks passed
@ogabrielides ogabrielides deleted the feat/encoding-ops branch May 13, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants