Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bump bls signatures 1.3.3 #97

Merged
merged 3 commits into from
Oct 10, 2024

Conversation

ogabrielides
Copy link
Collaborator

@ogabrielides ogabrielides commented Oct 9, 2024

Issue being fixed or feature implemented

This PR bumps the BLS library to 1.3.3.
This version includes dashpay/bls-signatures#95 which expects to solves GMP build failures in mobile CI.

What was done?

How Has This Been Tested?

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@ogabrielides
Copy link
Collaborator Author

CI task Tests and XCode framework passed

Copy link

@HashEngineering HashEngineering left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@Syn-McJ Syn-McJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@pankcuf
Copy link
Collaborator

pankcuf commented Oct 10, 2024

LGTM

@ogabrielides ogabrielides merged commit 7dda948 into dashpay:main Oct 10, 2024
2 checks passed
@ogabrielides ogabrielides deleted the bump_bls_signatures_1.3.3 branch October 10, 2024 07:48
@pankcuf pankcuf mentioned this pull request Oct 11, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants